Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the request uri dispatchers resolve the service and operation through Utils.getServiceAndOperationPart, getOperationName and parseRequestURLForServiceAndOperation, which searched the whole To address for the last occurrence of the service context path and cut the query string only afterwards. AxisServlet and AxisHttpService put the query string into the To address for REST requests, so GET /axis2/services/Echo?next=/axis2/services/Admin/deleteAll ran Admin/deleteAll, and POST /axis2/services/Echo/axis2/services/Admin reached Admin through the repeated suffix, while the container, a servlet filter or a reverse proxy matched its URL patterns against /services/Echo, which is where SECURITY.md says endpoint authentication lives. strip the query string before the search in all three helpers and take the first occurrence of the service context path for the service; the operation keeps the right-to-left search for the service name, since a context root can legitimately repeat it earlier in the path. the kernel dispatcher tests and UtilsParseRequestTest gain cases that fail before the change, and a webapp integration test shows that GET /services/NoSuchService?next=/axis2/services/Version/getVersion returned the Version response before and does not after. the kernel, transport/http and webapp-tests suites pass.