Repository navigation
apply the metadata exposure gate to ListFaultyServices - #1314
Merged
robertlazarski merged 1 commit intoOct 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ListingAgent.processListFaultyServices now only passes the service named by
serviceNameto listFaultyService.jsp when it passes the same Utils.isHiddenService / isMetadataExposed check processListServices applies. GET /services/ListFaultyServices?serviceName=X is anonymous and the page renders the service's EPR, documentation and every operation, but the route checked neither control, so a service deployed with exposeServiceMetadata=false or hiddenService=true was withheld from /services/, ?wsdl, ?xsd and the rest yet fully described here to anyone who knows or guesses its name. SECURITY.md lists exposeServiceMetadata as enforced uniformly across the servlet paths, and this was the one route left out. A withheld service now renders the same as an unknown one, so the page doesn't confirm it exists either. ServiceListingFilterTest gets a regression that fails before the change (the NotExposed service reaches the model) and passes after; the transport-http module's verify is green (111 tests).