Repository navigation
Conversation
|
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The newly cached level variables remain unused, causing warnings that break compilation under Arrow’s CHECKIN debug configuration with -Wall -Werror.
1 open issue
What changed in this PR
This PR optimizes level counting in the C++ Parquet column writer to make the counting loops easier to vectorize, with no intended user-facing changes.
Changes:
- Replace repeated-row counting loops with
std::count. - Accumulate definition-level counts locally before updating output parameters.
| File | Description |
|---|---|
cpp/src/parquet/column_writer.cc |
Optimize repetition- and definition-level counting in the writer. |
Review effort: Balanced
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
mapleFU
commented
Oct 29, 2026
HuaHuaY
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Rationale for this change
Optimize level counting in parquet column writer.
See: https://godbolt.org/z/qhEGa418x
What changes are included in this PR?
Some naive changes, this separate some dependencies, thus the code would be easy to vectorize.
Are these changes tested?
Covered by existing
Are there any user-facing changes?
No
Was AI used for this PR?
PR code and description written by:
Reviewed before submission by: