Repository navigation
Fix nested values in MapMessage - #2672
Merged
Merged
Conversation
This fixes the string encoding for MapMessages so that nested strings are properly returned as String values again instead of UTF8Buffers This is a fix for a regression introduced in apache#2080 This closes apache#2669
tabish121
reviewed
Oct 15, 2026
tabish121
previously approved these changes
Oct 15, 2026
tabish121
left a comment
Contributor
There was a problem hiding this comment.
From what I can recall of the decoding mechanism for the Map contents this seems like it should handle the nested versions correctly now
mattrpav
previously approved these changes
Oct 15, 2026
tabish121
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the string encoding for MapMessages so that nested strings are properly returned as String values again instead of UTF8Buffers
This PR also adds a bunch of missing tests for MarshallingSupport and to ActiveMQMapMesage to verify the nested types
This is a fix for a regression introduced in #2080
This closes #2669