Repository navigation
feat(otel): Add OpenTelemetry distributed tracing support - #1769
Merged
Merged
Conversation
jbonofre
changed the title
jbonofre
force-pushed
the
add-opentelemetry-support
branch
from
March 26, 2026 05:08
0e1e69d to
176f5f5
Compare
jeanouii
reviewed
Apr 10, 2026
jeanouii
left a comment
jeanouii
left a comment
Contributor
There was a problem hiding this comment.
Great PR and a good start.
I've added a couple of notes and questions.
It's been a while since I worked with this.
jbonofre
force-pushed
the
add-opentelemetry-support
branch
from
July 9, 2026 15:16
176f5f5 to
b55e0a6
Compare
jbonofre
force-pushed
the
add-opentelemetry-support
branch
from
July 16, 2026 12:06
b55e0a6 to
225e05a
Compare
Member
Author
|
@cshannon wdyt about this one for 6.3.0? |
Contributor
I haven't looked at this at all and this definitely needs to wait. Did
I think 6.4.0 makes more sense, I don't think anyone else has paid attention to this (I know I haven't) and adding a major new framework like this is a pretty big deal, even if it's off by default. I think it would be good to have some more time. |
Member
Author
|
6.4.0 is good idea. |
jbonofre
force-pushed
the
add-opentelemetry-support
branch
2 times, most recently
from
September 29, 2026 09:57
ef8c660 to
a890f90
Compare
mattrpav
reviewed
Oct 2, 2026
jbonofre
force-pushed
the
add-opentelemetry-support
branch
from
October 15, 2026 12:32
2ca3a64 to
f68470e
Compare
Member
Author
cshannon
approved these changes
Oct 15, 2026
cshannon
left a comment
cshannon
left a comment
Contributor
There was a problem hiding this comment.
LGTM, it's a new plugin and off by default so it's good to get it into 6.4.0 for people to try it out. It could be expanded in future releases to add more tracing in other broker methods or fix any bugs that show up.
Contributor
|
The build failure due to my bad JMX SSL merge, which is now fixed and merged. A rebase of the PR, or a Rebase+Merge should fix it. |
New activemq-opentelemetry module that instruments the broker using the OpenTelemetry API. The plugin traces send (PRODUCER), dispatch (CONSUMER), and acknowledge (INTERNAL) operations with W3C TraceContext propagation and standard OTel messaging semantic conventions. Depends on opentelemetry-api only; users bring their own SDK and exporter at runtime. Included in the distribution with example configuration.
- Fix OTel semantic convention attribute names: messaging.system -> messaging.system.name messaging.operation -> messaging.operation.type messaging.client_id -> messaging.client.id (dot notation) - Initialize propagator and tracer once in constructor instead of per-invocation - Bound dispatchSpans map to prevent unbounded growth / span leaks; oldest span is ended and evicted when the limit is exceeded - Add comment explaining setMarshalledProperties(null) in TextMapSetter - Replace Thread.sleep() in tests with Wait.waitFor() pattern - Document topic fan-out span behavior in class Javadoc
…PSHOT) The module's parent POM referenced activemq-parent:6.3.0-SNAPSHOT, which no longer exists since the root pom.xml was bumped to 6.4.0-SNAPSHOT, breaking CI reactor resolution.
…fix example config - Wire activemq-opentelemetry into activemq-spring (optional dependency and maven-xbean-plugin includes) so that openTelemetryPlugin is generated in activemq.xsd and recognized by XBean Spring - Remove unnecessary jetty.xml import and ws transport connector from activemq-opentelemetry.xml to pass XML validation and standalone broker start tests
…onstants, semconv fixes - Add messagingSystem property (default 'activemq') - Use AttributeKey constants for attribute keys and constants for values - Use messaging.system and the 'settle' operation type per semantic conventions - Resolve OpenTelemetry lazily and allow explicit injection via setOpenTelemetry - Log trace context read failures; null-safe span error status - Document deliver/ack span semantics and dispatch span cap
jbonofre
force-pushed
the
add-opentelemetry-support
branch
from
October 15, 2026 14:39
ef89585 to
d854170
Compare
github-project-automation
Bot
moved this from In review
to Done
in Apache ActiveMQ v6.4.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New activemq-opentelemetry module that instruments the broker using the OpenTelemetry API. The plugin traces send (PRODUCER), dispatch (CONSUMER), and acknowledge (INTERNAL) operations with W3C TraceContext propagation and standard OTel messaging semantic conventions.
Depends on opentelemetry-api only; users bring their own SDK and exporter at runtime. Included in the distribution with example configuration. Maybe we should add a default SDK/exporter in the ActiveMQ distribution, just wondering 😄