Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/aria/menu/menu-item.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
*/

import {
booleanAttribute,
computed,
Directive,
effect,
Expand Down Expand Up @@ -68,7 +69,7 @@ export class MenuItem<V> implements OnInit, OnDestroy {
readonly value = input<V | undefined>(undefined);

/** Whether the menu item is disabled. */
readonly disabled = input<boolean>(false);
readonly disabled = input(false, {transform: booleanAttribute});

/** The search term associated with the menu item. */
readonly searchTerm = model<string>('');
Expand Down
30 changes: 30 additions & 0 deletions src/aria/menu/menu.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -556,6 +556,24 @@ describe('Standalone Menu Pattern', () => {
});
});

describe('disabled attribute', () => {
it('should treat a bare disabled attribute as disabled', () => {
TestBed.resetTestingModule();
TestBed.configureTestingModule({
imports: [MenuItemDisabledAttributeExample],
});
const disabledFixture = TestBed.createComponent(MenuItemDisabledAttributeExample);
disabledFixture.detectChanges();

const items = disabledFixture.debugElement
.queryAll(By.directive(MenuItem))
.map(debugEl => debugEl.nativeElement as HTMLElement);

expect(items[0].getAttribute('aria-disabled')).toBe('false');
expect(items[1].getAttribute('aria-disabled')).toBe('true');
});
});

describe('structural validations', () => {
let consoleSpy: jasmine.Spy;

Expand Down Expand Up @@ -1486,3 +1504,15 @@ class CdkOverlayMenuExample {
class MenuItemRoleOverrideExample {
customRole = signal<'menuitem' | 'menuitemradio' | 'menuitemcheckbox'>('menuitemcheckbox');
}

@Component({
template: `
<div ngMenu>
<div ngMenuItem value="item0">Item 0</div>
<div ngMenuItem value="item1" disabled>Item 1</div>
</div>
`,
imports: [Menu, MenuItem],
changeDetection: ChangeDetectionStrategy.Eager,
})
class MenuItemDisabledAttributeExample {}
Loading