Repository navigation
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Karma test runner to check options.coverage.enabled instead of options.coverage when verifying dependencies, and introduces a new unit test suite to validate this behavior. The review feedback suggests simplifying the newly added tests by replacing the asynchronous assertions with synchronous Jasmine matchers, as the validateDependencies method is synchronous.
alan-agius4
reviewed
Oct 23, 2026
alan-agius4
added
the
target: patch
alan-agius4
approved these changes
Oct 27, 2026
…bled The upfront dependency validation of the unit-test builder's karma runner checks the truthiness of the normalized `coverage` option, which is always an object since the introduction of the advanced coverage options. As a result, `ng test` with the karma runner fails with a `MissingDependenciesError` requesting the `karma-coverage` package even when coverage is disabled. Check the `enabled` property instead, matching the vitest runner and the karma executor. A new unit spec for the karma runner's dependency validation fails without this change.
alan-agius4
force-pushed
the
fix/unit-test-karma-coverage-dependency
branch
from
October 27, 2026 15:37
2526ef4 to
9ab90d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upfront dependency validation of the unit-test builder's karma runner checks the truthiness of the normalized
coverageoption, which is always an object since the introduction of the advanced coverage options. As a result,ng testwith the karma runner fails with aMissingDependenciesErrorrequesting thekarma-coveragepackage even when coverage is disabled. Check theenabledproperty instead, matching the vitest runner and the karma executor. A new unit spec for the karma runner's dependency validation fails without this change.