Skip to content

fix(@schematics/angular): show routing module suffixes in findModule error #34374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgp1130 merged 1 commit into from
Oct 16, 2026
Merged

fix(@schematics/angular): show routing module suffixes in findModule error #34374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/schematics/angular/utility/find-module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export function findModule(

const errorMsg = foundRoutingModule
? 'Could not find a non Routing NgModule.' +
`\nModules with suffix '${routingModuleExt}' are strictly reserved for routing.` +
`\nModules with suffix '${routingModuleExtensions.join("' or '")}' are strictly reserved for routing.` +
`\nUse the '--skip-import' option to skip importing in NgModule.`
: `Could not find an NgModule. Use the '--skip-import' option to skip importing in NgModule.`;

Expand Down
3 changes: 3 additions & 0 deletions packages/schematics/angular/utility/find-module_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ describe('find-module', () => {
expect(() => findModule(host, 'foo/src/app/anything-routing')).toThrowError(
/Could not find a non Routing NgModule/,
);
expect(() => findModule(host, 'foo/src/app/anything-routing')).toThrowError(
/Modules with suffix '-routing-module\.ts' or '-routing\.module\.ts' are strictly reserved/,
);
});

it('should throw if two modules found', () => {
Expand Down
Loading