Repository navigation
fix: make IonReader.getBytes incremental for text and tree readers - #1175
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1175 +/- ##
============================================
+ Coverage 67.23% 68.36% +1.12%
- Complexity 5484 5737 +253
============================================
Files 159 160 +1
Lines 23025 23491 +466
Branches 4126 4231 +105
============================================
+ Hits 15481 16059 +578
+ Misses 6262 6132 -130
- Partials 1282 1300 +18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
NovemberZulu
approved these changes
Nov 4, 2026
Successive `getBytes` calls on the same lob now continue where the previous call stopped in the text and DOM readers, matching the binary reader. The tree reader also honours `offset` and no longer throws when the buffer is smaller than the lob. Javadoc documents the semantics. Removes the `getBytes` test skip for non-binary readers and adds coverage for chunked reads, reset on next value, null lobs, and argument checks.
tgregg
force-pushed
the
fix-getbytes-incremental
branch
from
November 4, 2026 23:24
0aaddde to
71237f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fix #319
Description of changes:
Successive
getBytescalls on the same lob now continue where the previous call stopped in the text and DOM readers, matching the binary reader. The tree reader also honoursoffsetand no longer throws when the buffer is smaller than the lob. Javadoc documents the semantics.Removes the
getBytestest skip for non-binary readers and adds coverage for chunked reads, reset on next value, null lobs, and argument checks.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.