Repository navigation
[BUGFIX-4674] Preserve dataset cache on extraction failures - #4675
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4674. Failed archive extraction now removes the destination only when that destination did not exist before the extraction attempt. This prevents an extraction error from recursively deleting pre-existing dataset-cache contents. Added a deterministic synthetic regression using a failing mocked archive; no dataset or service is used.
Validation
_extract_archivefailure regression passed with a pre-existing cache sentinel.--checkpassed for both changed Python files.git diff --checkand Python AST parsing passed.python/graphscope/proto/op_def_pb2.py; import fails ingraphscope/framework/errors.pybefore test collection. No real dataset, service, or project runtime was started.