Skip to content

[BUGFIX-4674] Preserve dataset cache on extraction failures - #4675

Open
dajiaohuang wants to merge 1 commit into
alibaba:mainfrom
dajiaohuang:bugfix/4674-cache-preservation
Open

dajiaohuang wants to merge 1 commit into
alibaba:mainfrom
dajiaohuang:bugfix/4674-cache-preservation

Conversation

@dajiaohuang

Copy link
Copy Markdown

Summary

Fixes #4674. Failed archive extraction now removes the destination only when that destination did not exist before the extraction attempt. This prevents an extraction error from recursively deleting pre-existing dataset-cache contents. Added a deterministic synthetic regression using a failing mocked archive; no dataset or service is used.

Validation

  • Synthetic _extract_archive failure regression passed with a pre-existing cache sentinel.
  • Black --check passed for both changed Python files.
  • git diff --check and Python AST parsing passed.
  • Attempted the focused pytest test, but collection is blocked because this source checkout lacks generated python/graphscope/proto/op_def_pb2.py; import fails in graphscope/framework/errors.py before test collection. No real dataset, service, or project runtime was started.

@welcome

welcome Bot commented Oct 23, 2026

Copy link
Copy Markdown

Thanks for submitting your first pull request! You are awesome! 🤗
Please make sure you have signed the CLA, as this is a mandatory check before a PR being merged.
Welcome to the GraphScope community! 🎉 You can meet the community on DingTalk or Slack.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Failed archive extraction deletes the dataset cache

2 participants