Skip to content

fix(config): preserve manual mode across model overrides - #557

Open
original4422 wants to merge 1 commit into
algorithmicsuperintelligence:mainfrom
original4422:fix/preserve-manual-mode-on-model-override
Open

original4422 wants to merge 1 commit into
algorithmicsuperintelligence:mainfrom
original4422:fix/preserve-manual-mode-on-model-override

Conversation

@original4422

Copy link
Copy Markdown

Summary

With llm.manual_mode: true, overriding --primary-model or --secondary-model rebuilds the model configs without the manual flag. The OpenAI backend then initializes its API client instead of using the manual task queue. Preserve manual_mode when propagating shared settings during rebuild:

 rebuild_models shared_config:
+    "manual_mode": self.manual_mode

Evidence

  • New regressions fail on the original code (6 subcase failures) and pass with the fix. They cover both model lists, primary/secondary CLI overrides, manual mode and normal-mode controls, and provider routing with the external client mocked.
  • Nearest CLI/provider/config tests: 29 passed.
  • python -m unittest discover tests: 915 tests, OK (2 skipped), using a placeholder API key.
  • Pinned isort 7.0.0 and Black 25.12.0 checks pass on both changed files; git diff --check passes. The pre-commit wrapper could not fetch its hook repository, so these two pinned tools were run directly.

Merge Danger

Door: two-way. Blast Radius: configuration. The change keeps rebuilt model settings consistent with initial model construction; tests intercept external execution and make no LLM requests.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant