Repository navigation
fix(config): preserve manual mode across model overrides - #557
Open
original4422 wants to merge 1 commit into
Open
original4422 wants to merge 1 commit into
original4422 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With
llm.manual_mode: true, overriding--primary-modelor--secondary-modelrebuilds the model configs without the manual flag. The OpenAI backend then initializes its API client instead of using the manual task queue. Preservemanual_modewhen propagating shared settings during rebuild:rebuild_models shared_config: + "manual_mode": self.manual_modeEvidence
python -m unittest discover tests: 915 tests, OK (2 skipped), using a placeholder API key.git diff --checkpasses. The pre-commit wrapper could not fetch its hook repository, so these two pinned tools were run directly.Merge Danger
Door: two-way. Blast Radius: configuration. The change keeps rebuilt model settings consistent with initial model construction; tests intercept external execution and make no LLM requests.