Repository navigation
Reject non-finite values in second/third autocorrelation evaluators - #553
Merged
codelion merged 1 commit intoOct 27, 2026
Conversation
Add an isfinite check on f_values (and on the reported C3) before the existing checks, plus a unit test covering NaN/inf rejection and a valid input.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #550 (partially: the autocorrelation evaluators; hexagon and circle packing are not changed here).
The
second_autocorr_ineqandthird_autocorr_ineqexample evaluators now reject non-finite function values (and a non-finite reported C3) with aValueError, which the existing handler returns as an error result.tests/test_autocorr_evaluators_finite.pychecks that NaN,infand-infare rejected and that a finite valid program is still scored.Scores for valid programs are unchanged.