Repository navigation
ci: drop flake8 in favor of ruff - #185
Merged
Merged
Conversation
ruff already runs in CI (check + format) and covers flake8's use; keeping both is redundant linting. - Remove flake8 from dev dependencies and uv.lock - Remove the flake8 CI step (ruff check/format remain) - Update README.md and CLAUDE.md lint instructions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI currently runs both flake8 and ruff; ruff fully supersedes flake8 here, so the duplicate lint pass and dependency go away:
flake8from dev dependencies (uv.lockupdated)ruff check+ruff format --checkremain)README.mdandCLAUDE.mdTest Plan
uv run ruff check flickr_api/: all checks passeduv run pytest: 291 passed locallyAutomated prep by Hermes maintainer.