Repository navigation
docs(wallets): new gas manager policies are created active - #1738
Open
blakecduncan wants to merge 1 commit into
Open
blakecduncan wants to merge 1 commit into
blakecduncan wants to merge 1 commit into
Conversation
Create Policy returns an active policy: CreatePolicyClient.insertPolicy in paymaster-services sets PolicyStatus.ACTIVE for every policy created without a gas pump. Update the Create Policy reference and drop the now-unneeded activation step from the pay-gas-with-any-token guide. Co-authored-by: Cursor <cursoragent@cursor.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🔗 Preview Mode
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Create Policy reference says a newly created policy starts
inactive, and the pay-gas-with-any-token guide tells readers to activate the policy before using it. New policies are actually createdactive. This updates both.CreatePolicyClient.insertPolicyin paymaster-services setsPolicyStatus.ACTIVEfor every new policy. The only exception is a policy created with a gas pump, which startsPENDING_APPROVAL, and gas pumps aren't part of the public docs. Sponsorship, ERC-20, and Solana policies all go through this insert, and it has worked this way since paymaster-services#227 (January 2025).Related Issues
Found during the prod smoke test for webhook request signing (#1730). A sponsorship policy created through
POST /api/gasManager/policycame back with"status": "active".Changes Made
src/openapi/admin/admin.yaml: the Create Policy description now says the new policy isactiveand can be used right away.content/wallets/pages/transactions/pay-gas-with-any-token/index.mdx: replaced the "New policies start inactive" step and itsPUT .../statuscall with a note that the policy can be used right away. The removed step was harmless, since setting an active policy to active is a no-op, but it was unnecessary.Testing
"status": "active"admin.yamlstill parses (js-yaml); the change is text inside an existing block scalarpnpm run validate). Not run locally; relying on CI