Repository navigation
fix: move to OpenShell 0.1.9 - #144
Merged
Merged
Conversation
Moves the OpenShell release this branch is built on from 0.1.6 to 0.1.9: the gateway and supervisor images the compatibility suite runs against, and the Go SDK at github.com/ai-openshell/sdk-go v0.1.9 (821d6895b248). The SDK is now its own module, github.com/ai-openshell/sdk-go, so the move also rewrites the BFF's imports from github.com/NVIDIA/OpenShell/sdk/go to it. Its packages and APIs are unchanged. OpenShell-Release: 0.1.9 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Gage Krumbach <gkrumbac@redhat.com>
From OpenShell 0.1.9 the SDK's profile endpoint is its policy endpoint (types.NetworkEndpoint = types.PolicyNetworkEndpoint), not a host, a port and a protocol. TestProviderProfileSurvivesTheSDKRoundTrip caught the converters still narrowing it. - ProviderProfileFromSDK and ProviderProfileToSDK convert endpoints with the policy endpoint converters. ToSDK still refuses an endpoint that does not survive the SDK's type unchanged (ErrEndpointNotExpressible). - The tests that expected an access preset, rules, ports or a path to be refused now expect them to reach the SDK whole. - mockSDK gains SandboxLogsWatch, new on ClientInterface. - gofmt the files whose imports the module-path rewrite left unsorted. clients/rawprofile.go and the store's EndpointsAreNarrow are unchanged; retiring them now that the SDK closes their gap is a change of its own. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Gage Krumbach <gkrumbac@redhat.com>
Gkrumbach07
force-pushed
the
bump/openshell-0.1.9
branch
from
November 19, 2026 17:05
eed3a70 to
b52b94e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
mainfrom OpenShell 0.1.6 to 0.1.9, the newest stable release. This is a manual bump because Follow upstream can't publish one yet: itsbumpjob has failed every day since 0.1.9 shipped, and thebump-botApp secrets don't exist.The SDK moved to
github.com/ai-openshell/sdk-go; #141 (merged) taught Follow upstream to follow it, and this bump uses that tooling.Commits
fix: move to OpenShell 0.1.9: the pin move, made by chore: follow the Go SDK at ai-openshell/sdk-go #141's own tooling rather than edited by hand:follow.py plan --version 0.1.9, thenfollow.py bumponmain. It is the commit the bot would have made, re-authored and signed off by me for DCO. It changes:gateway-pins.json: gateway and supervisor0.1.9by digest,sdkv0.1.9go.mod/go.sum:github.com/ai-openshell/sdk-go v0.1.9(821d6895b248)fix(bff): follow the SDK carrying profile endpoints whole: the source migration (hard fact 17: this is the source link, not the wire).types.NetworkEndpoint = types.PolicyNetworkEndpoint), with access, enforcement, rules, ports, path and so on.TestProviderProfileSurvivesTheSDKRoundTripcaught our converters still cutting it down to host, port and protocol. They now reuse the policy endpoint converters inpolicyproto.go.ProviderProfileToSDKstill refuses any endpoint that doesn't come back unchanged.mockSDKgainsSandboxLogsWatch, which is new onClientInterface.gofmton 14 files whose imports the module-path rewrite left unsorted. chore: follow the Go SDK at ai-openshell/sdk-go #141's rewrite should probably rungofmtitself.Skipped on the way: 0.1.7 and 0.1.8. Same gateway line (0.1), so the built-in release line doesn't change.
Tested
follow.py validate-pins --go-mod backend/go.modandnode scripts/gateway-range.mjs --checkpass.go build ./...,go vet ./...andgo test ./...inbackend/pass.Not run locally:
golangci-lint: the local binary is too old for Go 1.26.CI runs both on this PR.
Follow-ups (not here)
clients/rawprofile.gocovers (hard fact 24) looks closed. Retire it along withEndpointsAreNarrow, and update hard fact 24, in a separate PR.🤖 Generated with Claude Code