Repository navigation
fix: isolate fresh review attempts without run collisions - #148
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fresh reviews of the same target previously used minute-only directory names, so fast sequential or concurrent invocations could append to the same history. Each fresh invocation now has a millisecond timestamp and UUID; explicit resume still selects its existing run, including legacy names. Console labels distinguish simultaneous attempts, and overlong target prefixes are hashed to keep generated run names within the filesystem component limit while retaining full target metadata.
Validation on
6dd2adff69823120026de81f48d7302f950fa0bf:ENAMETOOLONGafter the longer stamp, and now passes with bounded run names; explicit resume also passes.node --test test/run-attempt.test.js test/runs.test.js test/loop.test.js test/console.test.js: 53 passed.node scripts/ci-check.mjs test: exit 0, 320 passed.node scripts/ci-check.mjs test:package: exit 0, 55 installed files and CLI regression checks passed.Exact final review command:
Known separate issues remain deferred: related-PR attempt labels were already absent on the base commit, and the existing Codex parser can reject a recovered stream containing an earlier error event. Neither behavior is addressed by this fix. The earlier incomplete review is not used as approval.