Repository navigation
fix: read Codex session IDs from provider metadata - #147
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex previously parsed session IDs from plain assistant output, so a review mentioning a fixture UUID could save that UUID and route a later reply to the wrong conversation. This change requests Codex JSONL for fresh and resumed reviewer/judge runs, reads IDs only from the provider
thread.startedevent, and extracts the final assistant response only after a completed turn. Live output remains readable and raw JSON is retained. Model selection and role sandbox arguments are preserved.Validation on
d462235d7101003124348ec94efc66349350c24b:node scripts/ci-check.mjs test: exit 0, 316 tests passed.node scripts/ci-check.mjs test:package: exit 0, 55 installed files and package CLI regression checks passed.Actual command (run from the isolated local worktree):
Codex CLI 0.163.0 help and the official non-interactive documentation confirm the JSONL contract and CLI flags. No live-model reproduction was needed for the original false-ID regression.