Repository navigation
test: synchronize timeout diagnostics before shutdown - #146
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI timeout fixture emitted its expected
partial reviewdiagnostic only from a SIGTERM callback, then allowed just 200 ms before SIGKILL. A busy or unscheduled reviewer can correctly be killed without running that callback, making the test fail despite correct product behavior.Write the diagnostic synchronously before the readiness marker and keep stdout silent so heartbeat assertions remain meaningful. Exercise both a responsive fixture and one whose JavaScript is deliberately blocked after readiness. The blocked variant fails before the correction with the same missing-output assertion and passes afterward. Existing failure-status, heartbeat, peer-result and pipe-drain assertions remain intact. Only the timeout test and changelog change; production code and deadlines are unchanged.
Historical evidence: Node 24/macOS job 119394920632 finished source tests with 301 passed and one missing-diagnostic assertion; package validation was skipped. The trace does not establish whether its SIGTERM callback executed, so this deterministic test flaw is verified without claiming the exact historical cause or a product output-loss fix.
Validation on
5f15a8d3d66d78faec97d5dafbab23509d05e419:node --test test/timeout.test.js: 22 passed, exit 0.node scripts/ci-check.mjs test: 310 passed, exit 0.node scripts/ci-check.mjs test:package: 55 packaged files and installed CLI checks passed, exit 0.Actual executed command: