Repository navigation
test: reap console fixtures before deleting their workspaces - #144
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The web-launch fixtures registered directory deletion before child termination in separate
t.afterhooks. If deleting the directory failed, Node skipped the later stop hook and left the console alive, keeping the test process running.Use one cleanup stack per console fixture: stop processes before removing their workspace, attempt every registered cleanup even after an error, and preserve cleanup failures. Add synchronized fault-injection regressions for both default-web and saved-console launches and include them in installed-package validation. No product behavior or existing test deadlines change.
Validation on
695e869270f88894478cf1b1910ec704f175f6b5:node --test test/web-launch-cleanup.test.js test/web-launch.test.js: 8 passed.node scripts/ci-check.mjs test: exit 0, 305 passed.node scripts/ci-check.mjs test:package: exit 0, 55 packaged files and installed CLI regressions passed.NO NEW FINDINGS, clean after one round (33.4s), same unchanged commit. Codex was configured for reviewer and judge; the clean first round required no judge triage.Exact executed review command:
Historical CI limitation: run 39635722771, job 119345518343 localized a package timeout to
web-launch.test.jsand a surviving console child, but its triggering cleanup error is unavailable. This fixes a deterministically reproduced cleanup defect consistent with that symptom; it does not prove that defect caused the historical timeout or that all recurring hangs are resolved.