Repository navigation
fix: retain reviewer sessions established by replies - #143
Merged
Merged
Conversation
added 15 commits
October 22, 2026 00:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a review has no resumable session ID, a reply can establish a new session but previously discarded its ID. Save and reuse session IDs from both standalone and automatic replies, preserving reviewer/judge separation and legacy events. Correlate replies with their selected event snapshot so late or abandoned replies cannot overwrite a newer review or accepted session change.
Retain known or explicitly reported IDs across failures. Accept generated IDs only after successful execution and a valid, nonempty response; reject malformed, failed and empty whole/tail responses before storing unconfirmed IDs. Regression fixtures cover repeated replies, concurrency order, missing executables, nonzero exits and synchronized timeouts.
Validation on
92e3316b5566aed5cf9069d4cbbd25b428bc8262:node scripts/ci-check.mjs test: exit 0, 302 tests passed.node scripts/ci-check.mjs test:package: exit 0, 55 packaged files and installed CLI checks passed.NO NEW FINDINGS, clean after one round (96.7s). The final reviewer inspected the diff and passed syntax checks; its read-only sandbox prevented write-heavy tests, which passed independently above. Codex was configured for both roles; this clean first round did not require judge triage.Exact executed review command:
The unchanged, pre-existing
run.jsonrepublishing race is documented and deferred; no fix for it is included. Separate master-CI diagnostics localized a package timeout to a web-launch test and console child but did not establish its root cause; no related source changes or retries are included. Live provider-session resumption is not claimed by local fake-provider regressions.