Skip to content

fix: report standalone reply invocation failures - #141

Merged
zzxwill merged 3 commits into
masterfrom
fix/reply-failure-exit-status
Oct 21, 2026
Merged

zzxwill merged 3 commits into
masterfrom
fix/reply-failure-exit-status

Conversation

@zzxwill

@zzxwill zzxwill commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

jury reply previously returned exit 0 even when a selected reviewer failed to start, exited with an error, or returned invalid structured output. Preserve all reply results, events, and artifacts, then return exit 1 with the failed reviewer names. Successful peers still complete and remain recorded. Valid answers containing remaining findings and dry runs continue to exit zero.

Three real subprocess regressions fail before the fix and pass afterward; controls cover remaining findings and dry runs. Documentation describes the exit-status distinction and retry command.

Validation on 2594af7914864499f08ce8fb9309d74862eebe9a:

  • Focused reply command tests: 5 passed; before the fix: 3 failed, 2 passed.
  • npm test: 282 passed, 0 failed.
  • npm run test:package: passed, including the new reply cases against the installed CLI.
  • git diff --check origin/master...HEAD: passed.
  • Actual Jury with Codex reviewer and Codex judge configured: exit 0, NO NEW FINDINGS, one round on the unchanged final commit; no amendments.

Portable equivalent of the executed local review command (recorded invocation used the absolute worktree path and redirected its output to an evidence log):

GIT_AUTHOR_NAME=zzxwill GIT_COMMITTER_NAME=zzxwill node bin/jury.js review --dir "$PWD" --trunk master --reviewer codex --judge codex --rounds 2 --summary 'Fix standalone jury reply returning exit zero when a reviewer invocation fails. Preserve all reply events, artifacts, and folded results before returning nonzero for failed agents. Three subprocess regressions fail before the fix and pass after; controls cover remaining findings and dry runs. All 282 tests and installed-package checks pass on this commit. Keep findings and fixes scoped to this failure-status behavior.' --web=false --push=false

Final-head remote CI is pending.

@zzxwill
zzxwill marked this pull request as ready for review October 21, 2026 15:59
@zzxwill
zzxwill merged commit 3108e72 into master Oct 21, 2026
8 checks passed
@zzxwill
zzxwill deleted the fix/reply-failure-exit-status branch October 21, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant