Repository navigation
fix: preserve UTF-8 across agent output chunks - #140
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a UTF-8 character crossed two process-output chunks, Jury decoded each fragment separately: a reviewer writing
caféproducedcaf��in the live stream and saved finding. Decode stdout and stderr incrementally so Unicode text survives pipe boundaries, structured result parsing, and failure diagnostics.Five real-child-process regressions failed before the fix and pass afterward. Acknowledgments force the split instead of assuming OS chunk sizes or relying on sleeps. Coverage includes two-, three-, and four-byte characters, structured results, and stderr diagnostics. Usage documentation and the changelog describe the correction.
Validation on
a9059df0d0dfae5bb0eaf8637efd90e8ea198714:node --test test/stream.test.js: 10 passed.npm test: 277 passed, 0 failed.npm run test:package: passed.git diff --check origin/master...HEAD: passed.Portable equivalent of the executed local command (the recorded invocation used the absolute worktree path and redirected output to an evidence log):
Final-head remote CI is pending.