Repository navigation
feat: add LiveObjects #731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: integration/v4
Are you sure you want to change the base?
Changes from all commits
2669df5
9d84e7d
ee2397d
e2600f3
16f8842
44afda6
ef954b5
11e7451
20760c3
75e08e4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| """LiveObjects: shared, conflict-free data structures stored on a realtime channel. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Although it's not been finalized, we agreed here https://ably.atlassian.net/wiki/x/GoAJ-g, that we put liveobjects everywhere in namespaces/package names/folders
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should rename in the uts, to avoid misleading |
||
|
|
||
| The public names are re-exported from :mod:`ably.pubsub.server`; the modules here | ||
| hold the implementation behind them, and the internal classes the specification | ||
| names (``ObjectsPool``, ``InternalLiveMap``, ``InternalLiveCounter`` and the wire | ||
| types). | ||
| """ | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Update the integration-tier count.
This command runs
rest/integration,realtime/integration, andobjects/integration. The explanation at Line 1011 still says “the two integration tiers.” Change it to “the three integration tiers” so the guidance matches the command.🧰 Tools
🪛 SkillSpector (2.11.2)
[warning] 825: [TM3] Unsafe Defaults: Tool defaults are unsafe or overly permissive (e.g. disabled TLS verification, no authentication, world-writable permissions). Unsafe defaults widen the attack surface.
Remediation: Override unsafe defaults with secure settings (verify=True, auth required, restrictive permissions). Review and harden all tool configurations.
(Tool Misuse (TM3))
🤖 Prompt for AI Agents