Repository navigation
fix(hero): centre the hero on desktop instead of leaving the sidebar band empty - #10
Merged
Merged
Conversation
…band empty From xl the home content keeps a 19rem left offset for the fixed sidebar, but the sidebar is hidden while the hero is on screen. The hero sat in that offset column: an empty band on the left, the text running into the right edge, and nothing lined up with the full-width header. - The hero cancels the offset at xl (SIDEBAR_BLEED_CLASS) and centres in the same max-w-7xl column as the header. - At xl the header-to-sidebar morph is measured from the hero: the crossfade runs over the last 30% of the viewport before the hero's bottom reaches the header, after its left column has scrolled away, so the sidebar never covers it. MorphSidebar fades in over the same range. - Below xl nothing changes (fixed 100-450px range for the header and the floating menu button). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
From
xl(≥1280px) the home content keeps a 19rem left offset for the fixed sidebar. The sidebar stays hidden while the hero is on screen, so at the top of the page the hero sat inside that offset column:It was most visible between about 1280 and 1600px.
Fix
xlthe hero cancels the offset (SIDEBAR_BLEED_CLASS = 'xl:-ml-[19rem]') and centres in the samemax-w-7xlcolumn as the header. The avatar card now lines up with the brand.xl, the header-to-sidebar morph range is measured from the hero (MorphNavProvider, kept up to date with aResizeObserver).MorphSidebarfades in over the same range, exposed asmorphRangein the context.xl: unchanged. The fixed 100–450px range still drives the header fade and the floating menu button.Test plan
npm run checkpasses (lint, typecheck, translations, journey timeline) andnpm run buildpasses.🤖 Generated with Claude Code