Repository navigation
avoid overwriting existing vai_profile.zip - #66
Merged
hackwa merged 1 commit intoOct 13, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep prior vai_profile.zip archives on successive collects
Summary
Running
vaiprofile-collect-dataa second time in the same hardware run directory no longer deletes the existingvai_profile.zip. The first archive stays in place, and later collections writevai_profile_1.zip,vai_profile_2.zip, and so on. Collected source files still move intovai_profile_dataor the next freevai_profile_data_<n>directory, so both the zip and the moved-file directory now use the same numbered-fallback scheme.This applies to the shell script and the Windows batch script. Downstream profiling that expects
vai_profile.zipstill finds the first collection there; later collections are additional archives rather than replacements.Changes
src/mldebug/script/vaiprofile-collect-datavai_profile.zipexists, write the next freevai_profile_<n>.zipsrc/mldebug/script/vaiprofile-collect-data.batBefore
The batch script deleted
vai_profile.zipand exited with an error if the delete failed.After
The batch script uses the same loop (
vai_profile_%ZN%.zip) before calling:make_zip.Motivation
vai_profile_dataalready avoided clobbering a previous collection by stepping tovai_profile_data_<n>. The zip path did the opposite: every run removedvai_profile.zipand wrote a new one, so an earlier archive from the same hardware run directory was lost. A second collect in one directory should keep the prior zip the same way it already keeps the prior data directory.