Repository navigation
Fixed/two h1 issue loginscreen - #14292
shahjehan-wpbrigade wants to merge 8 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @shahjehan-wpbrigade. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| ?> | ||
| <div id="login"> | ||
| <h1 role="presentation" class="wp-login-logo"><a href="<?php echo esc_url( $login_header_url ); ?>"><?php echo $login_header_text; ?></a></h1> | ||
| <div role="presentation" class="wp-login-logo"><a href="<?php echo esc_url( $login_header_url ); ?>"><?php echo $login_header_text; ?></a></div> |
There was a problem hiding this comment.
I personally don't like this approach. Instead updating it here better to update the accessibility h1.
There was a problem hiding this comment.
@mukeshpanchal27 We can change this to a logo for an H2. Need your thoughts?
There was a problem hiding this comment.
Thanks for the feedback, @mukeshpanchal27!
I’ve updated the approach to fix the semantic duplicate <h1> issue without entirely removing the heading element. Instead of hardcoding a <div>, the code now dynamically checks if a title heading is present (such as on the email confirmation screen) and sets the logo tag accordingly:
When another primary <h1> heading exists, the logo wrapper correctly falls back to an <h2> with role="presentation".
When no competing <h1> exists, the logo wrapper retains its semantic <h1> status.
Let me know if this approach looks better or if any further adjustments are needed!
|
Introduce in r59138 / Core-51786 cc. @joedolson |
setup-php only warns when a tool fails to install, which left `wp` missing and failed the "Download WordPress" step with exit code 127. Install the official WP-CLI phar when it is not already available. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…exists. Output the login logo as a presentational h2 when the screen-reader page title h1 is printed, or when the admin email confirmation form provides its own h1. Otherwise, the logo becomes the page's h1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-wpbrigade/wordpress-develop into fixed/two-h1-issue-loginscreen
2 participants
Trac ticket:
Use of AI Tools
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.