Repository navigation
feat(dev)!: same-entity-schema and same-error-reason fail the family audit - #574
Merged
Merged
Conversation
…audit Owner ruling NEED-2578 A: the two rules the family audit measured first in 0.98.0 printed warnings; now they fail like every other rule. So that no published CLI turns red today, the 11 differences measured on 2026-11-13 are declared as parity-group differences with review_after 2026-11-27 and a reason each (3 in messengers, 8 in gcal-shared, under the budget of 10). A difference of these two rules names no CLI list (`entity hit`, `reason profile.unknown: code`): which CLIs share an entity or reason changes with each release (zm joined the address-refused finding within an hour), so a listed target would go stale on every publish. Its review_after retires it, not a stale check. Checked: the family audit from bitrix24-cli main (throwaway HOME, DBUS disabled on the CLI runs) exits 0 with 0 new findings for any of the 9 CLIs; a test shows an unlisted difference accepts its finding and a different entity still blocks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
leemour
added a commit
that referenced
this pull request
Nov 13, 2026
Dates the changelog and raises the version for #573 and #574. Only package.json and the CHANGELOG heading change. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
Owner ruling NEED-2578 A: the family audit rules
same-entity-schemaandsame-error-reasonmust fail, not warn. Ships in 0.99.0 with #573.Why
0.98.0 printed their findings as warnings, so a new divergence between CLIs went unnoticed.
What
cli-dev audit --familyfails on new findings of both rules.review_after: 2026-11-27and a reason each, so no published CLI turns red today:messengers:entity contact_context,entity contact_preparation,entity linked_person(max, tg, wa)gcal-shared:entity api_method,entity scheduled_job,entity hit,entity deal,entity lead,entity product,reason ai.address-refused=model.address-refused,reason profile.unknown: codereview_afterdate retires it instead of a stale check.oauth.missingvssession.missingis not a finding today, so it has no row.Testing
DBUS_SESSION_BUS_ADDRESS=disabled:on the CLI runs): exit 0, 0 new findings for any of the 9 CLIs.vitest run(68 files, 1117 tests), typecheck, biome,docs:check,docs:lint.🤖 Generated with Claude Code