Repository navigation
docs: fix 9 typos in code comments and an error message - #247
Open
Avicennasis wants to merge 1 commit into
Open
Avicennasis wants to merge 1 commit into
Avicennasis wants to merge 1 commit into
Conversation
Comment typos across the parsers (then/than, contans, juse, lease, though, it's/its, VB8 -> VP8 in the WebP header table, matching the 'VP8 '/'VP8L'/'VP8X' values the code switches on), plus 'Literal to large' -> 'Literal too large' in a JSONParserError message that JSONParser rescues internally. Signed-off-by: Léon Avic Simmons <Avicennasis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix typos in comments across seven files, plus one error message:
lib/parsers/json_parser/validator.rb: "much larger then necessary" → "than"; error message"Literal to large at ..."→"Literal too large at ..."lib/parsers/exif_parser.rb: "contans" → "contains"lib/care.rb: "juse use the only page" → "just use"lib/parsers/webp_parser.rb: the header table saidVB8where it meansVP8("VB8 ", "VB8X", "The VB8 variant", "the VB8 data"). It now matches the'VP8'/'VP8L'/'VP8X'valuesread_dataswitches on.lib/remote_io.rb: "at lease not" → "at least not"lib/parsers/jpeg_parser.rb: "it's bits and bobs" → "its"lib/parsers/mpeg_parser.rb: "looping though the stream" → "through"The only non-comment change is the
JSONParserErrormessage text.JSONParserrescues that error, and no spec asserts on the message.Deliberately left alone: the Measurometer counter
format_parser.parser.care.page_reads_from_upsteaminlib/care.rbis misspelled, but renaming an emitted metric would break any dashboard or alert keyed on it. That is your call.No functional changes — comments plus one error-message string.