Skip to content

ci: fail the preview step when wrangler fails #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rtomas merged 1 commit into from
Oct 22, 2026
Merged

ci: fail the preview step when wrangler fails #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ jobs:
- name: Upload preview
if: github.event_name == 'pull_request'
id: preview
# An explicit `shell: bash` adds -o pipefail, so tee cannot hide a wrangler failure
shell: bash
run: |
pnpm exec wrangler versions upload --preview-alias "pr-${{ github.event.pull_request.number }}" | tee upload.log
url=$(grep -oE 'https://pr-[^ ]+\.workers\.dev' upload.log | head -1)
Expand Down
Loading