Repository navigation
Allow slow Docker lifecycle operations on busy hosts - #24
Merged
Merged
Conversation
Raise gateway preflight container creation/removal and Compose teardown timeouts from 60 to 300 seconds for busy hosts. Keep task execution budgets and egress leases unchanged. Update cleanup assertions and cover simulated slow teardown while preserving the private manifest directory until cleanup succeeds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On busy hosts, Docker/containerd can take more than 60 seconds to create or remove containers. The shared runner can therefore fail a gateway preflight or teardown even when the operation would complete successfully with a longer bounded wait.
Introduce a shared 300-second lifecycle timeout for gateway preflight container execution, preflight container removal, and
docker compose down. Task execution budgets and egress leases are unchanged. Existing ownership checks and cleanup failure handling remain in place.Update the cleanup timeout assertions and add a regression that simulates slow teardown, checking that the private runtime directory remains available until teardown succeeds and is then removed.
This is the first of two related PRs. The follow-up PR revises three retrieval task packages; this PR contains only the shared lifecycle fix and its tests.
Commit:
1bd88b57237c0a2276c8e915d3f6cf6defdd8d5c—Allow bounded slow Docker lifecycle operations.Changed files:
scripts/harbor_environments.pyscripts/tests/test_egress_adapter.pyValidation evidence
Checks ran in an isolated worktree based on fork
mainat21ab7a32ed75d4d463b6bc91deb0f304bcb3e3b5, containing only these two file changes:python -m unittest discover -s scripts/tests -p 'test_*.py' python scripts/check_release.py git diff --checkThe slow-teardown case uses mocks; these checks do not demonstrate a real Docker operation taking more than 60 seconds. Live Docker/model trials were not rerun for this commit. Integration and CI checks against the current upstream base remain part of PR review.
Contributor checklist
Maintainer merge checklist