Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #179, scoped to the two P2P corruption-routing gaps found during review.
ALREADY_KNOWN.This PR does not contain the changes from #179, change consensus/wire formats, update chainbase, or fix the separate undo-session destructor issue identified in that audit. It can be reviewed independently against
master.Verification
python3 tests/p2p/test_corruption_recovery.py -v— passes 26 compiled C++ scenarios using the actual production entrypoint/policy and network transaction-handler bodies with controlled storage/application dependencies.-fsyntax-onlywith the repository submodule headers, Boost 1.83 and the generated hardfork header.git diff --check— clean.The regressions cover enabled/disabled recovery, transaction corruption and ordinary transaction outcomes, initial and retried block corruption, ordinary block classification, unchanged synchronization skip flags, and recovery exceptions escaping nested retry handling. They do not run a live node or perform snapshot restoration.
Full node linking, the full consensus suite, and end-to-end snapshot recovery were not run locally. No production deployment was performed.