[EmandM]

Purpose of this PR

Ensure as many callbacks as possible are wrapped in try/catch blocks to avoid user generated errors throwing into internal netcode functionality.

Jira ticket

Reported internally.

Changelog

• Fixed: Ensures all callbacks are wrapped with exception handling to avoid silent errors.

Documentation

• No documentation changes or additions were necessary.

Testing & QA (How your changes can be verified during release Playtest)

Functional Testing

Manual testing :

• Manual testing done

Automated tests:

• Covered by existing automated tests
• Covered by new automated tests

Does the change require QA team to:

• Review automated tests?
• Execute manual tests?
• Provide feedback about the PR?

If any boxes above are checked the QA team will be automatically added as a PR reviewer.

Up-port

not needed

Backports

Might be worth a backport?

[u-pr]

⚠️ Some settings were ignored in '.pr_agent.toml (repository root)' repo settings

Check the configuration's TOML syntax, permitted settings, and size limit. See the error below.

---

Error message:
Ignored prohibited settings: github_app.handle_pr_actions. Permitted settings were applied.

Configuration content:

# This is the configuration for the u-pr bot
# https://github.cds.internal.unity3d.com/unity/u-pr
# For configuration of this file:
# https://developer.portal.internal.unity.com/catalog/default/component/u-pr/docs/configuration/automatic_runs/

[github_app]
handle_pr_actions = ['opened', 'ready_for_review']  # PR events that auto-run pr_commands
pr_commands       = ["/harness-review"]             # what runs on those events
reviewer_commands = ["/harness-review"]             # what runs when @u-pr is added as reviewer

[u-pr]

💡 Harness Review

This broadly hardens user callback execution, but several exception paths change observable ownership and visibility behavior, and some shared exception boundaries still suppress later lifecycle notifications.

_{Reviewed commit c319570}

_{🤖 Helpful? 👍/👎}

[codecov-github-com]

Codecov Report

Attention: Patch coverage is 43.34140% with 234 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...cts/Runtime/SceneManagement/NetworkSceneManager.cs	48.35%	47 Missing ⚠️
....netcode.gameobjects/Runtime/Core/NetworkObject.cs	49.23%	33 Missing ⚠️
...ime/Components/Helpers/UnifiedUpdateConnections.cs	0.00%	28 Missing ⚠️
...tcode.gameobjects/Runtime/Core/NetworkBehaviour.cs	34.28%	23 Missing ⚠️
...cts/Runtime/Connection/NetworkConnectionManager.cs	37.93%	18 Missing ⚠️
...time/SceneManagement/DefaultSceneManagerHandler.cs	0.00%	18 Missing ⚠️
...ameobjects/Runtime/Spawning/NetworkSpawnManager.cs	18.75%	13 Missing ⚠️
...objects/Runtime/NetworkVariable/NetworkVariable.cs	42.85%	12 Missing ⚠️
...netcode.gameobjects/Runtime/Core/NetworkManager.cs	79.59%	10 Missing ⚠️
...meobjects/Runtime/Spawning/NetworkPrefabHandler.cs	42.85%	8 Missing ⚠️
... and 5 more

@@                Coverage Diff                @@
##           develop-3.x.x    #4161      +/-   ##
=================================================
- Coverage          76.91%   76.33%   -0.59%     
=================================================
  Files                159      159              
  Lines              27603    27953     +350     
=================================================
+ Hits               21230    21337     +107     
- Misses              6373     6616     +243     

Flag	Coverage Δ
NGOv2_project_testproject_ubuntu	75.37% <43.34%> (-0.60%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
.../Runtime/Components/Helpers/ComponentController.cs	39.08% <100.00%> (+0.70%)	⬆️
...me/Messaging/Messages/ConnectionApprovedMessage.cs	67.35% <100.00%> (ø)
...cts/Runtime/NetworkVariable/NetworkVariableBase.cs	87.50% <ø> (ø)
...cts/Runtime/Components/Helpers/UnifiedBootstrap.cs	38.46% <42.85%> (-0.43%)	⬇️
...time/NetworkVariable/AnticipatedNetworkVariable.cs	75.14% <42.85%> (-1.51%)	⬇️
...Runtime/NetworkVariable/Collections/NetworkList.cs	78.93% <42.85%> (-0.83%)	⬇️
...gameobjects/Runtime/Transports/NetworkTransport.cs	77.08% <42.85%> (-6.25%)	⬇️
...meobjects/Runtime/Spawning/NetworkPrefabHandler.cs	64.95% <42.85%> (-1.71%)	⬇️
...e.gameobjects/Runtime/Timing/AnticipationSystem.cs	87.50% <42.85%> (-12.50%)	⬇️
...netcode.gameobjects/Runtime/Core/NetworkManager.cs	74.95% <79.59%> (-0.08%)	⬇️
... and 8 more

Components	Coverage Δ
com.unity.netcode.gameobjects	76.33% <41.37%> (-0.59%)	⬇️

ℹ️ Need help interpreting these results?