[unitydavidlo]

Description

Port of the Editor fix for UUM-151403. Actions enabled early in startup (e.g. in a SubsystemRegistration callback or an Entities system's OnCreate) were being disabled by the BeforeSceneLoad hook in InputActionState. It ran in the Editor with domain reload disabled and on every Player launch. Removed the hook and, with domain reload disabled, exiting Play Mode now removes the onActionChange and onActionControlsChanged callbacks added during Play Mode. Callbacks added in Edit Mode, or owned by a Unity object that still exists such as an open Editor window, are kept.

Testing status & QA

Added InputActionStatePlayModeTests, which enters real Play Mode with domain reload on and off. Ran locally in 6000.3.25f1 batchmode with -nographics:

• New tests: 3 passed.
• PlayMode suite: 1939 passed, 0 failed, 77 skipped.
• EditMode suite: 81 passed, 12 failed, 1 skipped. The failures are UI tests that need a graphics device (InputActionsEditorTests, InputActionReferencePropertyDrawerEditorTests, CustomProcessorEnumTest), so need to see them on CI.

Overall Product Risks

• Complexity: Low
• Halo Effect: Medium, it changes what gets reset when entering Play Mode with domain reload disabled.

Comments to reviewers

• The code is the same as the Editor fix, only the test path changed.
• The hook here also reset everything in Players, not just in the Editor with domain reload disabled, so both cases are fixed by this.

Checklist

Before review:

• Changelog entry added.
  • Explains the change in Changed, Fixed, Added sections.
  • For API change contains an example snippet and/or migration example.
  • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
  • Jira port for the next release set as "Resolved".
• Tests added/changed, if applicable.
  • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
  • Performance tests.
  • Integration tests.
• Docs for new/changed API's.
  • Xmldoc cross references are set correctly.
  • Added explanation how the API works.
  • Usage code examples added.
  • The manual is updated, if needed.

During merge:

• Commit message for squash-merge is prefixed with one of the list:
  • NEW: ___.
  • FIX: ___.
  • DOCS: ___.
  • CHANGE: ___.
  • RELEASE: 1.1.0-preview.3.

[u-pr]

💡 Harness Review

The change removes the reset that disabled startup actions and adds callback cleanup on Play Mode exit, but the regression tests do not reliably select their intended reload configuration.

_{Reviewed commit 98fd21c}

_{🤖 Helpful? 👍/👎}

[u-pr]

The disableDomainReload=true case still reloads the domain with the checked-in Unity 6000.0 settings, leaving s_EarlyAction null after ExitPlayMode. The project sets enterPlayModeOptionsEnabled to false, and SetDomainReloadDisabled only changes enterPlayModeOptions. Unity 6000.0 ignores those options until enterPlayModeOptionsEnabled is enabled. The assertion on s_EarlyAction.enabled then throws, and the callback test also runs with the wrong reload configuration. Save enterPlayModeOptionsEnabled alongside the existing options. Enable it when configuring the tests. Restore it in TearDown.

_{🤖 Helpful? 👍/👎}

[unitydavidlo]

Fixed in ae4c058, the tests now enable the enter play mode options and save and restore the enabled flag too.

[unitydavidlo]

/review

[codecov-github-com]

Codecov Report

Attention: Patch coverage is 97.45763% with 3 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...nputSystem.Editor/InputActionStatePlayModeTests.cs	96.73%	3 Missing ⚠️

@@             Coverage Diff             @@
##           develop    #2500      +/-   ##
===========================================
+ Coverage    78.96%   79.01%   +0.04%     
===========================================
  Files          767      768       +1     
  Lines       140949   141125     +176     
===========================================
+ Hits        111305   111504     +199     
+ Misses       29644    29621      -23     

Flag	Coverage Δ
inputsystem_MacOS_6000.0	5.31% <0.00%> (+<0.01%)	⬆️
inputsystem_MacOS_6000.0_project	77.57% <97.45%> (+0.06%)	⬆️
inputsystem_MacOS_6000.3	5.31% <0.00%> (+<0.01%)	⬆️
inputsystem_MacOS_6000.3_project	77.57% <97.45%> (+0.06%)	⬆️
inputsystem_MacOS_6000.6	5.30% <0.00%> (+<0.01%)	⬆️
inputsystem_MacOS_6000.6_project	77.63% <97.45%> (+0.06%)	⬆️
inputsystem_Ubuntu_6000.0	5.31% <0.00%> (+<0.01%)	⬆️
inputsystem_Ubuntu_6000.0_project	77.48% <97.45%> (+0.06%)	⬆️
inputsystem_Ubuntu_6000.3	5.31% <0.00%> (+<0.01%)	⬆️
inputsystem_Ubuntu_6000.3_project	77.48% <97.45%> (+0.06%)	⬆️
inputsystem_Ubuntu_6000.6	5.30% <0.00%> (+<0.01%)	⬆️
inputsystem_Ubuntu_6000.6_project	77.54% <97.45%> (+0.06%)	⬆️
inputsystem_Windows_6000.0	5.31% <0.00%> (+<0.01%)	⬆️
inputsystem_Windows_6000.0_project	77.69% <97.45%> (+0.06%)	⬆️
inputsystem_Windows_6000.3	5.31% <0.00%> (+<0.01%)	⬆️
inputsystem_Windows_6000.3_project	77.70% <97.45%> (+0.06%)	⬆️
inputsystem_Windows_6000.6	5.30% <0.00%> (+<0.01%)	⬆️
inputsystem_Windows_6000.6_project	77.76% <97.45%> (+0.06%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...InputSystem/Editor/InputSystemEditorInitializer.cs	74.92% <100.00%> (+2.30%)	⬆️
...em/InputSystem/Runtime/Actions/InputActionState.cs	92.56% <100.00%> (+0.39%)	⬆️
...nputSystem.Editor/InputActionStatePlayModeTests.cs	96.73% <96.73%> (ø)

... and 5 files with indirect coverage changes

ℹ️ Need help interpreting these results?

[u-pr]

💡 Harness Review

The change removes the startup action-state reset and adds callback cleanup when leaving Play Mode. I examined initialization order, callback subscription lifetimes, and the new domain-reload tests, and found no new actionable issues.

_{Reviewed commit ae4c058}

_{⚠️ Earlier blocking findings with unresolved threads: 1. The rating above does not cover them; resolve each thread after addressing it.}

_{🤖 Helpful? 👍/👎}