[unitydavidlo]

Description

Backport of https://github.cds.internal.unity3d.com/unity/unity/pull/133412, see that PR for full context. Since 6000.5 UnityEditor.Remote.GenericRemote lives in the UnityEditor.GenericRemoteModule assembly, so UnityRemoteSupport never found it, never registered its message handler and touch from Unity Remote 5 was ignored.

Trunk only looks in the new assembly. This package still supports 6000.0 where it's in UnityEditor, so here we look there first and fall back to the module.

Jira: UUM-155327

Testing status & QA

Added UnityRemoteTests.Remote_CanFindEditorRemoteAPI, same as trunk. The branch has the test in its own commit first so it can be checked against the unfixed code.

Ran UnityRemoteTests locally in PlayMode on both commits:

Editor	Test only (3ae73e8)	With fix (a725b88)
6000.6.0a7	4 failed	4 passed
6000.0.80f1	4 passed	4 passed

Not tested manually with Unity Remote 5 on a device for this port, it was for the trunk PR.

Overall Product Risks

• Complexity: Low
• Halo Effect: Low

Comments to reviewers

• The assembly name is a string, so if GenericRemote moves again this breaks silently. The new test is there to catch that.
• Publish Dry Run, and All Functional Tests which depends on it, fail on PVP-40-1 because of the ## [Unreleased] - yyyy-mm-dd changelog header already on develop from the 1.20.2 bump, not anything in this PR.
• The macOS 6000.3 Validate job failed once on an Editor startup log error (NativeWindowManager:Windowing System isn't initialized yet.) and passed on a rerun.

Checklist

Before review:

• Changelog entry added.
  • Explains the change in Changed, Fixed, Added sections.
  • For API change contains an example snippet and/or migration example.
  • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
  • Jira port for the next release set as "Resolved".
• Tests added/changed, if applicable.
  • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
  • Performance tests.
  • Integration tests.
• Docs for new/changed API's.
  • Xmldoc cross references are set correctly.
  • Added explanation how the API works.
  • Usage code examples added.
  • The manual is updated, if needed.

🤖 Generated with Claude Code

[u-pr]

💡 Harness Review

The assembly fallback preserves the existing lookup while accommodating the relocated Unity Remote API. I examined handler registration, gyro API lookups, the new regression test, and the changelog entry; no actionable issues were found.

_{Reviewed commit a725b88}

_{🤖 Helpful? 👍/👎}

[codecov-github-com]

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...m/Editor/Plugins/UnityRemote/UnityRemoteSupport.cs	66.66%	1 Missing ⚠️

@@             Coverage Diff             @@
##           develop    #2499      +/-   ##
===========================================
+ Coverage    78.96%   78.98%   +0.01%     
===========================================
  Files          767      767              
  Lines       140949   141011      +62     
===========================================
+ Hits        111305   111374      +69     
+ Misses       29644    29637       -7     

Flag	Coverage Δ
inputsystem_MacOS_6000.0	5.30% <66.66%> (ø)
inputsystem_MacOS_6000.0_project	77.53% <83.33%> (+0.01%)	⬆️
inputsystem_MacOS_6000.3	5.30% <66.66%> (ø)
inputsystem_MacOS_6000.3_project	77.52% <83.33%> (+0.02%)	⬆️
inputsystem_MacOS_6000.6	5.29% <66.66%> (ø)
inputsystem_MacOS_6000.6_project	77.58% <83.33%> (+0.01%)	⬆️
inputsystem_Ubuntu_6000.0	5.31% <66.66%> (ø)
inputsystem_Ubuntu_6000.0_project	77.44% <83.33%> (+0.01%)	⬆️
inputsystem_Ubuntu_6000.3	5.31% <66.66%> (ø)
inputsystem_Ubuntu_6000.3_project	77.43% <83.33%> (+0.01%)	⬆️
inputsystem_Ubuntu_6000.6	5.30% <66.66%> (ø)
inputsystem_Ubuntu_6000.6_project	77.49% <83.33%> (+0.01%)	⬆️
inputsystem_Windows_6000.0	5.30% <66.66%> (ø)
inputsystem_Windows_6000.0_project	77.66% <83.33%> (+0.02%)	⬆️
inputsystem_Windows_6000.3	5.30% <66.66%> (ø)
inputsystem_Windows_6000.3_project	77.65% <83.33%> (+0.01%)	⬆️
inputsystem_Windows_6000.6	5.29% <66.66%> (ø)
inputsystem_Windows_6000.6_project	77.71% <83.33%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...sets/Tests/InputSystem/Plugins/UnityRemoteTests.cs	97.52% <100.00%> (+0.06%)	⬆️
...m/Editor/Plugins/UnityRemote/UnityRemoteSupport.cs	91.42% <66.66%> (-0.51%)	⬇️

... and 2 files with indirect coverage changes

ℹ️ Need help interpreting these results?