Repository navigation
Preserve shared lexical environments in compact EtsIR JSON - #442
Merged
Merged
Conversation
Contributor
CaelmBleidd
force-pushed
the
caelmbleidd/ts-lexical-env-dto-references
branch
from
October 15, 2026 08:30
20dfa67 to
199ebe0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The acquired
lodash.jsdependency expands shared closure-environment types into 755,694,861 JSON characters, exceeding Node's string limit and failing full-project frontend generation withRangeError: Invalid string length.Serialize complete lexical environments once in a file-local table and use indexed references at their use sites. The Kotlin reader validates references and memoizes conversion to the existing environment model, preserving every captured local and function signature. Legacy inline JSON remains supported; invalid indices and cycles fail explicitly.
Validation:
-Xmx768m.No symbolic machine or full test suite was run. Final combined frontend packaging and experiment startup remain separate validation steps.
Diff scope: production changes span 7 files (+179/-9 lines); focused tests and test-consumer helpers span 6 files (+372/-5 lines).