Repository navigation
Conversation
|
|
bvmcode
force-pushed
the
issue_4044
branch
2 times, most recently
from
October 14, 2026 00:42
82599eb to
01c99d8
Compare
Airport stations now resolve to coordinates, so fewer reports share missing latitude and longitude and get dropped as duplicates. Document the lookup argument as a string, with the accepted values described in the parameter text.
…okup change. Newly located stations change which observations survive point thinning, so the existing images no longer match.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Closes #4044
airport-codes.csv is now read as station records keyed by airport id. Those records participate in StationLookup, including airports that do not appear in the other station tables. A missing elevation stays missing.
Station-id lookup is unchanged: station_info['FYOW'] still returns the highest-priority definition. Two new methods search the individual source tables. lookup_all returns every definition of a station id, and find(synop_id=...) finds records by WMO/SYNOP id, including a lower-priority definition such as 68004 on the master.txt record for FYOW. Integer, string, and whole-number float ids match. add_station_lat_lon(df, lookup='synop_id') uses that search. The default lookup still resolves station ids only, and placeholder SYNOP values ('', 99999, and 999999) stay unresolved.
Checklist