Repository navigation
fix(website): apply UI5 theme to main document on theme change - #14158
Merged
Merged
Conversation
|
🚀 Deployed on https://pr-14158--ui5-webcomponents-preview.netlify.app |
ilhan007
approved these changes
Oct 19, 2026
|
🧹 Preview deployment cleaned up: https://pr-14158--ui5-webcomponents.netlify.app |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, setTheme() was only called inside the playground iframes
(via ReactPlayground.tsx), so switching themes in the Settings menu
had no effect on the main document. Pages like /illustrations kept
stale --sap CSS variables regardless of the selected theme.
Add a useEffect in Root.js that registers theme assets and calls the
UI5 setTheme() on the main document whenever the theme context changes.