Repository navigation
Conversation
devtomtom
force-pushed
the
poc-rework-middleware-code-coverage
branch
from
October 19, 2026 09:33
f339a67 to
31b4e2f
Compare
…dle handling and source maps BREAKING CHANGE: Rework the code-coverage middleware for UI5 CLI v5. - Support input source maps and report coverage against original sources, resolving the input source map via sourceMappingURL - Switch integration tests to UI5 CLI v5 only and expand coverage across projects and build configs JIRA: CPOUI5FOUNDATION-1350 JIRA: CPOUI5FOUNDATION-1203
devtomtom
force-pushed
the
poc-rework-middleware-code-coverage
branch
from
October 19, 2026 09:46
31b4e2f to
596ac88
Compare
devtomtom
changed the title
devtomtom
force-pushed
the
poc-rework-middleware-code-coverage
branch
from
October 19, 2026 11:20
bd97294 to
aff646c
Compare
d3xter666
reviewed
Oct 20, 2026
d3xter666
left a comment
d3xter666
left a comment
Member
There was a problem hiding this comment.
The solution works as expected and I have tested the scenarios in the fixtures and whether they provide coverage and correct paths to the files.
As this is a breaking change it's worth mentioning why is it breaking.
For exmaple: specVersion 5 is not available in @ui5/cli version 4 as well as builtResources
matz3
reviewed
Oct 22, 2026
matz3
left a comment
matz3
left a comment
Member
There was a problem hiding this comment.
Just a first review, but looks very good so far 👍🏻
I have tested it locally on macOS and want to test on Windows.
| // falling back to the `//@ui5-bundle` content marker — the tag is absent when the minify | ||
| // task is skipped, but the marker is always present. | ||
| const source = await matchedResource.getString(); | ||
| if (isBundleResource(matchedResource, log) || isBundleSource(source)) { |
Member
There was a problem hiding this comment.
- If the tag is found, we do not have to read the source via
matchedResource.getString(), right? This affects performance / memory consumption, which might become relevant for very large bundles. - I do not see a direct connection of an excluded minify task and therefore the
IsBundletag not being present. I could reproduce it locally. I do not see a reason why the tag should be omitted in such a case, so this sounds like a bug to me.
Member
Author
There was a problem hiding this comment.
- Done.
- You're right,
minifyisn't the cause. Acc. to AI, the tag isn't present for pre-built build-manifest artifacts.
…IsBundle tag is absent And align sourceMappingURL handling with @ui5/builder
devtomtom
force-pushed
the
poc-rework-middleware-code-coverage
branch
from
October 23, 2026 13:50
f1943e6 to
c2fc717
Compare
Member
I also tested on Windows, incl. TypeScript and it works as expected. Rewriting the paths to strip the drive (e.g. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: CPOUI5FOUNDATION-1350
JIRA: CPOUI5FOUNDATION-1203