Repository navigation
tests: measure probe rate cap by process wall time - #50
Merged
Merged
Conversation
The server thread stamped each accept, so a descheduled thread could record two queued connections back to back and fail the 80ms gap check under load. The whole probe run must now last at least (N - 1) * 80ms for N connections, which load can only lengthen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a flake in
probe_non_agent_prints_empty_record_and_respects_rateseen once under a full parallel workspace run. The server thread stamped each accept, so when it was descheduled two queued connections were recorded back to back and the 80ms gap check failed even though the client had paced them.The test now asserts the whole probe process ran for at least (N - 1) * 80ms for N connections. Load can only lengthen that, never shorten it. Sanity check: with
--rate 1000the assertion fails in 70ms, so it still guards the cap.