Skip to content

security: harden scanner boundaries and upgrade dependencies - #23

Merged
jaschadub merged 2 commits into
mainfrom
security/harden-scanner-boundaries
Nov 4, 2026
Merged

jaschadub merged 2 commits into
mainfrom
security/harden-scanner-boundaries

Conversation

@jaschadub

@jaschadub jaschadub commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Status: ready

AgentPin 0.3.1 (the compatible security backport from ThirdKeyAI/AgentPin#11) is published on crates.io. The lockfile was regenerated registry-only and all checks were rerun without overrides.

Fixes

  • DNS-rebinding/Host/Origin protections, remote auth validation, and dashboard anti-framing headers.
  • Notification timeouts, prompt cancellation, passive capture and aggregate detector/evidence limits.
  • Bounded API/history/storage/backups; transactional quota failures preserve history; private SQLite files.
  • Safe release tag validation, locked builds, pinned images, dependency updates, and Rust/audit CI.
  • Configuration precedence and credential clearing across changed destinations.
  • Safe-Rust YAML parsing with preserved scalar types, port keys, aliases/defaults, duplicate-key rejection, and redacted diagnostics.
  • P-256 upgrade and compatible AgentPin 0.3.1 dependency; signed datasets and wire formats unchanged.

GitHub release environment now requires jaschadub approval, disallows admin bypass, and accepts only v* tags. An active no-bypass ruleset prevents version-tag updates/deletion. Self-review is allowed because jaschadub is the only human admin; this is an explicit approval gate, not two-person review.

Verification

  • 263 AgentSniff tests passed, including live disposable PostgreSQL/Redis backends, with the local AgentPin candidate override.
  • Formatting, Clippy with warnings denied, and cargo audit --deny warnings pass for that candidate graph.
  • Independent investigator/reviewer completed; confirmed compatibility/minimum-version issues corrected and retested.
  • Isolated live scanner: all 8 signed datasets verify; scan completes; hostile Host returns403; state modes700/600. No external scan traffic.
  • AgentPin main:261 tests; backport:180 tests; each has one pre-existing ignored doc example. Both have clean audits, Rust1.89 checks, and green PR CI.

Unverified: Windows/macOS binaries, actual eBPF attachment, full enrichment image rebuild, and privileged release signing run.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T17:30:27.552092Z 87a7fa1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jaschadub
jaschadub merged commit 9129841 into main Nov 4, 2026
1 check passed
@jaschadub
jaschadub deleted the security/harden-scanner-boundaries branch November 4, 2026 18:40
jaschadub added a commit that referenced this pull request Nov 4, 2026
…ries

security: harden scanner boundaries and upgrade dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants