Skip to content

Fix slowsort comparable - #15566

Closed
fredaesiofori wants to merge 4 commits into
TheAlgorithms:masterfrom
fredaesiofori:fix-slowsort-comparable
Closed

fredaesiofori wants to merge 4 commits into
TheAlgorithms:masterfrom
fredaesiofori:fix-slowsort-comparable

Conversation

@fredaesiofori

@fredaesiofori fredaesiofori commented Oct 12, 2026 •

Copy link
Copy Markdown

Describe your change

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Fixes #15234

Update sorts/slowsort.py to support generic comparable types (such as strings and floating-point numbers) instead of integers only.

  • Implemented Comparable protocol using typing.Protocol and parameterized with TypeVar.
  • Updated function type annotations to list[T].
  • Added in-place doctests for string and float sequences.

Checklist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues, then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Copilot AI balanced review requested due to automatic review settings October 12, 2026 23:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Oct 12, 2026
@algorithms-keeper

Copy link
Copy Markdown

Closing this pull request as invalid

@fredaesiofori, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Oct 12, 2026
@fredaesiofori

Copy link
Copy Markdown
Author

Fixes #15234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sorts: make algorithms sort any comparable items, not just ints

4 participants