Repository navigation
Conversation
5 of 8 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #842.
Viewpoint.go()now throws when the viewpoint has no world, with a message that says to setworldon the viewpoint orViewpoints.worldbefore creating or loading viewpoints (for example withBCFTopics.load). This matches the existing error a few lines below for a camera that is not anOrthoPerspectiveCamera, and is added to the method's@throwsdocs.updateCamera()andtakeSnapshot()are unchanged: they already tell the caller by resolvingfalse.Test:
src/core/Viewpoints/viewpoint-go.test.tscreates a viewpoint whileViewpoints.worldisnulland expectsgo()to reject. It fails onmain("promise resolved undefined instead of rejecting") and passes with this change. eslint is clean on both files.Behaviour change to note: code that called
go()on a viewpoint without a world and relied on it doing nothing will now get a rejected promise.