You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(create): avoid missing favicon requests in Start apps - #583
React and Solid Start apps now declare an empty favicon, so opening a generated app does not trigger a request for the removed favicon.ico asset.
AI review notes:
The blank-preset change deliberately removed the favicon asset. Browsers still request /favicon.ico when the document has no icon metadata, producing a console 404 and failing PocketBase's existing runtime guard. This adds an inline empty SVG icon to both Start root-template branches for each framework. It preserves the asset-free preset and does not change router-only scaffolds, dependencies, workflows or guards.
Regression: the unchanged initial-render matrix case at PocketBase #572 head 5adb654f failed on http://localhost:3000/favicon.ico. Applying only these two template changes to that isolated source made the same case pass, including generation, production build, types and the existing runtime guard. This is an overlay verification, not a claim that #572 contains this patch. The separate recovery case already passed without it.
Validation: normal pre-commit hooks passed ten builds, source lint, 570 unit tests and all 22 blocking browser cases.
Measured source-template gzip increases are React +69 bytes and Solid +68 bytes. These are compressed EJS assets, not runtime bundle or package-size measurements. The change adds static document metadata and no executable runtime logic.
Hosted browser setup remains dependent on #582's supported-runner fix and its required Core review. No merge or release is claimed.
Summary by CodeRabbit
New Features
New React and Solid Start projects now include an empty favicon by default.
No actionable comments were generated in the recent review.
Walkthrough
React and Solid Start scaffold root-route templates now add an empty SVG data-URL favicon link alongside the existing stylesheet link. A Changeset declares a patch for @tanstack/create.
React and Solid Start scaffold route templates add an empty SVG data-URL favicon link. The existing stylesheet link remains. The Changeset declares a patch for @tanstack/create.
Generated React and Solid Start apps will declare an empty favicon, so browsers stop requesting the removed /favicon.ico. The change is small, template-only and easy to revert. The hosted browser CI job fails on a runner setup issue unrelated to this diff.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "fix(create): avoid missing favicon requests in Start apps" matches the main change. The PR adds inline empty SVG favicon metadata to the React and Solid Start root templates so browsers sto…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "fix(create): avoid missing favicon requests in Start apps" matches the main change. The PR adds inline empty SVG favicon metadata to the React and Solid Start root templates so browsers stop requesting the removed /favicon.ico. The title is specific, concise, and uses a conventional commit scope. It does not name the React and Solid templates, but it does not conflict with the changeset.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Fix failing CI checks
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React and Solid Start apps now declare an empty favicon, so opening a generated app does not trigger a request for the removed
favicon.icoasset.Summary by CodeRabbit