Skip to content

fix(create): avoid missing favicon requests in Start apps - #583

Open
tannerlinsley wants to merge 1 commit into
mainfrom
codex/explicit-empty-favicon
Open

tannerlinsley wants to merge 1 commit into
mainfrom
codex/explicit-empty-favicon

Conversation

@tannerlinsley

@tannerlinsley tannerlinsley commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

React and Solid Start apps now declare an empty favicon, so opening a generated app does not trigger a request for the removed favicon.ico asset.

AI review notes:
The blank-preset change deliberately removed the favicon asset. Browsers still request /favicon.ico when the document has no icon metadata, producing a console 404 and failing PocketBase's existing runtime guard. This adds an inline empty SVG icon to both Start root-template branches for each framework. It preserves the asset-free preset and does not change router-only scaffolds, dependencies, workflows or guards.

Regression: the unchanged initial-render matrix case at PocketBase #572 head 5adb654f failed on http://localhost:3000/favicon.ico. Applying only these two template changes to that isolated source made the same case pass, including generation, production build, types and the existing runtime guard. This is an overlay verification, not a claim that #572 contains this patch. The separate recovery case already passed without it.

Validation: normal pre-commit hooks passed ten builds, source lint, 570 unit tests and all 22 blocking browser cases.

Measured source-template gzip increases are React +69 bytes and Solid +68 bytes. These are compressed EJS assets, not runtime bundle or package-size measurements. The change adds static document metadata and no executable runtime logic.

Hosted browser setup remains dependent on #582's supported-runner fix and its required Core review. No merge or release is claimed.

Summary by CodeRabbit

  • New Features
    • New React and Solid Start projects now include an empty favicon by default.

@changeset-bot

changeset-bot Bot commented Nov 19, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c9e1cee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@tanstack/create Patch
create-start-app Patch
create-tanstack-app Patch
create-tanstack Patch
create-tsrouter-app Patch
@tanstack/create-start Patch
@tanstack/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

React and Solid Start scaffold root-route templates now add an empty SVG data-URL favicon link alongside the existing stylesheet link. A Changeset declares a patch for @tanstack/create.

Changes: Scaffold favicon

Layer / File(s) Summary
Root-route links
packages/create/src/frameworks/react/project/base/src/routes/__root.tsx.ejs, packages/create/src/frameworks/solid/project/base/src/routes/__root.tsx.ejs, .changeset/explicit-empty-favicon.md
React and Solid Start scaffold route templates add an empty SVG data-URL favicon link. The existing stylesheet link remains. The Changeset declares a patch for @tanstack/create.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: brenelz

Merge Risk: Minimal · up to c9e1c

Generated React and Solid Start apps will declare an empty favicon, so browsers stop requesting the removed /favicon.ico. The change is small, template-only and easy to revert. The hosted browser CI job fails on a runner setup issue unrelated to this diff.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "fix(create): avoid missing favicon requests in Start apps" matches the main change. The PR adds inline empty SVG favicon metadata to the React and Solid Start root templates so browsers sto…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "fix(create): avoid missing favicon requests in Start apps" matches the main change. The PR adds inline empty SVG favicon metadata to the React and Solid Start root templates so browsers stop requesting the removed /favicon.ico. The title is specific, concise, and uses a conventional commit scope. It does not name the React and Solid templates, but it does not conflict with the changeset.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
Fix failing CI checks

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a50a7344-9f2b-4c21-9f3a-b2af6af08e92
Commits

Reviewing files that changed from the base of the PR and between 40e0043 and c9e1cee.

Files selected for processing: 3

  • .changeset/explicit-empty-favicon.md
  • packages/create/src/frameworks/react/project/base/src/routes/__root.tsx.ejs
  • packages/create/src/frameworks/solid/project/base/src/routes/__root.tsx.ejs

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant