Skip to content

Interactive router only option - #514

Draft
DogPawHat wants to merge 6 commits into
TanStack:mainfrom
DogPawHat:interactive-router-only-option
Draft

DogPawHat wants to merge 6 commits into
TanStack:mainfrom
DogPawHat:interactive-router-only-option

Conversation

@DogPawHat

Copy link
Copy Markdown
Contributor

No description provided.

Prompt 'Use Tanstack Router without Start?' in interactive mode when
router-only intent is not already explicit via --router-only, a legacy
template, or --template/--starter. Answering yes sets cliOptions.routerOnly
so template, deployment, add-on, and example prompts are skipped.
Strict inverse of --router-only: explicitly opts into TanStack Start and
suppresses the interactive router-only prompt. Errors when combined with
--router-only and ignores legacy router-only templates in favor of Start.
@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@tannerlinsley

tannerlinsley commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Thanks Ciarán! The follow-ups now preserve explicit Start choices, including legacy template aliases and template IDs. This is still a draft. Once the hosted checks finish, is it ready for broader review?

AI review notes:
Follow-up head: f768957073740d36f61555f9df013f067c40ebaf, with current main 40e00437 merged while preserving your original commits. The new mode question is skipped when Start integrations, a template, a starter or the blank preset were explicitly requested. --router-and-start also normalizes legacy template aliases before choosing Start.
The agent completed the normal commit hook on this head: ten project builds, source lint, 577 unit tests and all 24 blocking browser cases. Generated apps ran outside the monorepo. The alias tests failed before the fix and passed afterward; the template-ID regression also failed before its guard was added.
Tests ran in an isolated sandbox with a public registry and asset allowlist proxy. The temporary Playwright proxy configuration was restored and is not committed. No deployment provider or live AI service was contacted.
Across the changed emitted JavaScript modules, gzip growth versus current main is 289 bytes: cli.js +139, options.js +102 and ui-prompts.js +48. These are per-module measurements verified against actual TypeScript build output, not package archive or startup measurements. No dependencies changed.
The exact-head PR and security workflows started normally. Security and provenance passed. Hosted browser job 135885807709 stopped during browser installation: Playwright does not support ffmpeg on ubuntu26.04-x64. It did not execute browser cases. The Ubuntu 24.04 runner correction in #582 still needs Core review. Hosted checks and normal review remain separate from the local results. Nothing here has merged or released, and interactive selection of Router-only add-ons in #522 remains separate.

@changeset-bot

changeset-bot Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f768957

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@tanstack/cli Minor
create-start-app Patch
create-tanstack-app Patch
create-tanstack Patch
create-tsrouter-app Patch
@tanstack/create-start Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants