[XxFran10xX]

Why

Main spark profiles (11-04) show one ~0.45 s tick every hour at restart + 1 h:

• CharacterDeaths.reconcile (224 ms), mostly FactionDeaths.collectKeys → Members.characterId, which threw and filled a stack trace for every non-ID string in every realm snapshot (~70 ms in fillInStackTrace alone).
• MapSystem.queueAllNations → updateMap (231 ms: faction saves and exports), plus the hourly vehicle decay and the 1- and 5-minute timers, all on the same tick.

Changes

• Members.characterId returns null for any key that is not 36 characters with dashes at 8/13/18/23 before parsing. Only that shape can equal a UUID's own string, so results are identical. A new test checks the dash fact over every UTF-16 character, every length 0–72, and the lenient forms UUID.fromString accepts, against the old logic.
• The hourly task (death reconcile, leaderless and held realm expiries) keeps its 1 h period. Its first run is now 30 min 30 s + 11 ticks after start, off every startup timer (1 s, 1 min, 5 min, hourly, map full update). The startup reconcile is unchanged. Every run checks the current state against the wall clock, so the only effect is that the first expiry check after a restart can come up to 29.5 min sooner, as any run in the hour already could.
• Vehicle decay keeps its schedule: it adds damage on each run, so moving its first run would change decay per restart.

Not changed

The daily settlement (1.3 s on Main) was investigated and left alone. The province recalculation must run after the day preparation, inactivity arming and route reset on the same tick to give an identical result, and the durable writes are an ordered chain that is already parallel within each batch.

Testing

• mvn verify on Windows: the same 28 Windows-only failures as unmodified main (directory fsync); no new failures. Linux CI is authoritative.
• Dev: spark profile over the first 65 min after restart, the reconcile at ~+30.5 min and the map full update at ~+60 min in different minutes; death flow (journal, succession) unchanged.

Dev test

Dev (TFMCDev01, 11-05, spark 16:13–17:14): CharacterDeaths.reconcile at 16:43 (start + 30.5 min, 4 ms, no fillInStackTrace under it); MapSystem.queueAllNations and vehicle decay at 17:12–17:13 (nation.json rewritten 17:13:26). Member lists and faction menu normal; no new SF warnings.

🤖 Generated with Claude Code

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn