Repository navigation
fix(vote): let members list vote categories once results are published - #391
Merged
Merged
Conversation
ListVoteCategories required vote_category:read, which members only get from the voting capability. Turning voting off to publish results left participants unable to list the categories the results page needs, and the page answered with a 500. Accept vote_result:read as well.
marftn
approved these changes
Oct 28, 2026
Co-authored-by: Martin Fontanet <11040743+marftn@users.noreply.github.com>
sabinem
added a commit
that referenced
this pull request
Oct 29, 2026
#391) (#394) * fix(vote): let members list vote categories once results are published ListVoteCategories required vote_category:read, which members only get from the voting capability. Turning voting off to publish results left participants unable to list the categories the results page needs, and the page answered with a 500. Accept vote_result:read as well. * Update components/backend/internal/service/vote_service.go --------- Co-authored-by: Sabine Maennel <5292683+sabinem@users.noreply.github.com> Co-authored-by: Martin Fontanet <11040743+marftn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ListVoteCategories required vote_category:read, which members only get from the voting capability. Turning voting off to publish results left participants unable to list the categories the results page needs, and the page answered with a 500. Accept vote_result:read as well.
Solves #390