Skip to content

feat: submission schema change - #377

Merged
sabinem merged 7 commits into
mainfrom
feat/submission-schema-change
Oct 27, 2026
Merged

sabinem merged 7 commits into
mainfrom
feat/submission-schema-change

Conversation

@marftn

@marftn marftn commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor
  • Add fields description and attachment_folder_url to the submission.
  • Update submission tests

The different fields are still optional because making result mandatory means a NOT NULL migration, which would stop the backend at startup if any existing row holds NULL, so we'll do it after the hackathon. In practice it doesn't changes much, because a missing result is already saved as "", and comes back unset when read.

@marftn marftn changed the title Feat/submission schema change feat: submission schema change Oct 23, 2026

@sabinem sabinem left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marftn Looks mostly good.

todo: we should at least put a length limit on the new fields.

It would also be good to check the url. Currently we don't do that anywhere, but with other instances it is easier to correct this later: with submissions we never update or delete those. So I think it would be a good place to start more rigorous checking here.

A small helper would be good, that checks:

// requireHTTPURL refuses a non-empty value that is not an absolute http(s) URL.
// Empty is allowed: the field is optional.

We always said the frontend is vibe coded and the backend is the guard, therefore I think it would make sense to add more checks there and especially for the versioned submissions.

@sabinem
sabinem changed the base branch from main to releese-v0.13.0 October 26, 2026 15:50
@sabinem
sabinem deleted the branch releese-v0.13.0 October 26, 2026 15:57
@sabinem sabinem closed this Oct 26, 2026
@sabinem

sabinem commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator

Sorry accidentially closed it when I did the branch renaming and pruned already merged branches. Please reopen and merge.

@marftn marftn reopened this Oct 26, 2026
@marftn
marftn changed the base branch from releese-v0.13.0 to nextrelease October 26, 2026 23:02
@sabinem
sabinem changed the base branch from nextrelease to main October 27, 2026 09:32
@sabinem
sabinem merged commit ef69e0c into main Oct 27, 2026
8 checks passed
@sabinem
sabinem deleted the feat/submission-schema-change branch October 27, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants