Repository navigation
feat: submission schema change - #377
Merged
Merged
Conversation
sabinem
requested changes
Oct 26, 2026
sabinem
left a comment
Collaborator
There was a problem hiding this comment.
@marftn Looks mostly good.
todo: we should at least put a length limit on the new fields.
It would also be good to check the url. Currently we don't do that anywhere, but with other instances it is easier to correct this later: with submissions we never update or delete those. So I think it would be a good place to start more rigorous checking here.
A small helper would be good, that checks:
// requireHTTPURL refuses a non-empty value that is not an absolute http(s) URL.
// Empty is allowed: the field is optional.
We always said the frontend is vibe coded and the backend is the guard, therefore I think it would make sense to add more checks there and especially for the versioned submissions.
Collaborator
|
Sorry accidentially closed it when I did the branch renaming and pruned already merged branches. Please reopen and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
descriptionandattachment_folder_urlto the submission.The different fields are still optional because making
resultmandatory means a NOT NULL migration, which would stop the backend at startup if any existing row holds NULL, so we'll do it after the hackathon. In practice it doesn't changes much, because a missingresultis already saved as"", and comes back unset when read.