Repository navigation
Brazilian to European Portuguese v1.8.2: managed local grammar checks and rule selection - #363
Merged
Merged
Conversation
Keep v1.7.0 as the rollback baseline and isolate the v1.8.0 experiment. Add a bounded LanguageTool client, review-first diagnostics, explicit-subject agreement allowlist, aligned English and MiniLM safeguards, candidate rechecks, and shared preview/batch settings. No model or Java installation, public cloud API or generative rewriting. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add verified LanguageTool and portable Java downloads, owned loopback server lifecycle, and advanced external-server mode. Preserve real grammar phrase suggestions and subtitle boundaries. Move reference/model settings beside dialogue/layout and document the opt-in v1.8.1 workflow. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add a grammar-only preset and per-rule exclusions for spelling, dialogue typography, style and other findings. Persist selections for preview and batch, filter rechecks consistently, and send explicit rule exclusions to LanguageTool. Include native dialog, settings and protocol regression tests; update experimental version to 1.8.2. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Move reference settings below the top-right actions, align dialogue/layout and dictionary right edges, and bound scrolling to preserve subtitle-review space. Validate native layout at minimum, standard and wide widths. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Classify LanguageTool findings independently of other review warnings while preserving multi-type rows, edits and Apply selections. Verify classification and native filter controls. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Normalize Só lembra-te to Lembra-te só and equivalent apenas/somente commands without moving adverbs in indicative, negative or subordinate uses. Reuse finite-clitic and imperative morphology, cover dialogue dashes and case, update the earlier exception tests and document the pt-PT rule. Verified episode S08E02 cue 659 through the published executable with all 902 cue IDs and timings preserved. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve existing articles across subtitle line breaks and prefer guarded resultative ficar for anatomical injuries. Clarify that tested agreement fixes work with managed and external grammar checkers. Validated 5,475 tests and actual S08E02 cue 305 with IDs, timings and source preserved. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds on the already merged baseline PR #362. Updates only the Brazilian to European Portuguese plugin and its tests to v1.8.2.
Validation
Platform and accuracy limits
Managed runtime execution has only been verified on Linux x64, not Windows/macOS or Flatpak. Native Java packages cover Linux/macOS x64 and ARM64, and Windows x64; Windows ARM64 deliberately uses x64 Java via OS emulation. Actual MiniLM inference was not exercised in candidate-gate tests (deterministic vectors). No full-corpus real LanguageTool accuracy/performance certification is claimed. Grammar checking and auto-fixes remain separate opt-ins.
Rollback
The standalone repository main now contains this version. Its experimental PR is closed. The pre-grammar v1.7.0 tag/release remains available: https://github.com/SMAP-git/BrazilianToEuropeanPortuguese/releases/tag/v1.7.0