Repository navigation
CI: test against arcade v0.6.3 - #7
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (run after CI went green on the PR head):
Out-of-diff observations:
Merge gate: This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testworkflow deploys to is bumped fromv0.5.0tov0.6.3(the latest arcade release), as the comment on theref:asks for each arcade release.git log v0.5.0..v0.6.3in arcade shows a landing page,/version.json,/robots.txt,/og.png, a canonicalLinkheader and a cleaner missing-registry error. The upload endpoint, its status codes and?activate=false, plus thehash-token/servecommands used by CI, are unchanged insrc/arcade/server.pyandsrc/arcade/__main__.py, so no change todeploy.shoraction.ymlis expected.Closes #6
Test plan
Test / deploy-to-a-real-arcadeis green on this head, with every existing step running against arcade v0.6.3: first deploy + "The game is live", re-run failure,skip-existing, wrong/empty token, empty slug, bad inputs, other non-2xx,activate: false, and the static-site deploy.test.ymlandaction.ymlparse as YAML locally.Compatibility
Backward-compatible for callers pinned to
@v1: only CI changes and the action is untouched. Because the PR touches.github/workflows/*, it is held for human review rather than auto-merged.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
drafted by Claude on behalf of Daniel Stephenson
🤖 Generated with Claude Code