Repository navigation
CI: test against arcade v0.6.6 - #13
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (one pass, anchored on CI run 40829049531):
Upstream check: Not covered: CI only exercises Merge gate: the change touches This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/test.ymlis bumped fromv0.6.4tov0.6.6, the latest tag on Stephenson-Software/arcade (v0.6.5was skipped over). The workflow comment asks for a bump with each arcade release.v0.6.4..v0.6.6was inspected before the bump. It adds arcade unit tests, a redrawnog.pngshare image and itsog-card/sources, CHANGELOG/README doc refreshes, and docstring-only edits tosrc/arcade/server.pyandsrc/arcade/__main__.py. ThePUT /api/games/<slug>/versions/<version>contract the action relies on (201 / 409 / 401-403 /?activate=false, tak and static bundles) is unchanged; arcade's README now spells out more of the 400 refusals that already existed. Nodeploy.shoraction.ymlchange is needed.No tracking issue — gap found during triage.
Skipped this cycle: #10 (
activate/skip-existingvalue handling) is still waiting on the owner's compatibility choice recorded on the issue.Test plan
Test/deploy-to-a-real-arcadepasses on the PR head with arcade v0.6.6: every existing step (first deploy, re-run failure and its message,skip-existingand its notice, wrong/empty token, empty slug, bad inputs, other non-2xx,activate: false, static site with a symlink through a trailing-slashurl) runs against the new server.Compatibility
No change to
action.ymlordeploy.sh; callers pinned to@v1are unaffected. Nothing needs a release.This PR touches
.github/workflows/*, so it is held for owner review rather than auto-merged.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson