Skip to content

CI: test against arcade v0.6.6 - #13

Merged
dmccoystephenson merged 1 commit into
mainfrom
feature/ci-arcade-v0.6.6
Oct 29, 2026
Merged

dmccoystephenson merged 1 commit into
mainfrom
feature/ci-arcade-v0.6.6

Conversation

@dmccoystephenson

Copy link
Copy Markdown
Member

Summary

  • The arcade release pinned in .github/workflows/test.yml is bumped from v0.6.4 to v0.6.6, the latest tag on Stephenson-Software/arcade (v0.6.5 was skipped over). The workflow comment asks for a bump with each arcade release.
  • v0.6.4..v0.6.6 was inspected before the bump. It adds arcade unit tests, a redrawn og.png share image and its og-card/ sources, CHANGELOG/README doc refreshes, and docstring-only edits to src/arcade/server.py and src/arcade/__main__.py. The PUT /api/games/<slug>/versions/<version> contract the action relies on (201 / 409 / 401-403 / ?activate=false, tak and static bundles) is unchanged; arcade's README now spells out more of the 400 refusals that already existed. No deploy.sh or action.yml change is needed.

No tracking issue — gap found during triage.

Skipped this cycle: #10 (activate/skip-existing value handling) is still waiting on the owner's compatibility choice recorded on the issue.

Test plan

  • Test / deploy-to-a-real-arcade passes on the PR head with arcade v0.6.6: every existing step (first deploy, re-run failure and its message, skip-existing and its notice, wrong/empty token, empty slug, bad inputs, other non-2xx, activate: false, static site with a symlink through a trailing-slash url) runs against the new server.

Compatibility

No change to action.yml or deploy.sh; callers pinned to @v1 are unaffected. Nothing needs a release.

This PR touches .github/workflows/*, so it is held for owner review rather than auto-merged.

This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).

🤖 Generated with Claude Code


drafted by Claude on behalf of Daniel Stephenson

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dmccoystephenson

Copy link
Copy Markdown
Member Author

Self-review rubric (one pass, anchored on CI run 40829049531):

  • Scope: PASS — the diff is one line, .github/workflows/test.yml:24 ref: v0.6.4 → ref: v0.6.6; nothing else changed.
  • Tests-new: PASS (not applicable) — no new input, output or fail/status branch was added.
  • Tests-fix: PASS (not applicable) — not a bug fix; no Closes reference.
  • Sibling structure / sibling renames: PASS (not applicable) — no new files, no renames.
  • Docs: PASS — the README "Tests" paragraph says "a pinned release" without naming a version, and the workflow comment ("Bump it with each arcade release") still holds; no action.yml/deploy.sh text describes the pin.
  • Issue resolution: PASS (not applicable) — no tracking issue; gap found at triage by comparing the pin against arcade's tags (latest v0.6.6).
  • CI: PASS — deploy-to-a-real-arcade is green on head 110ad89. The log shows ref: v0.6.6 checked out and every scenario step ran: "Live at" for the first deploy and the static site, the skip-existing notice, "Stored (not live)" for activate: false, and all failure-path steps succeeded.
  • Input parity / output parity: PASS — action.yml, deploy.sh and the README Inputs table are untouched and were in parity on main.
  • Token hygiene / failure messages / pre-network validation: PASS (not applicable) — deploy.sh is untouched.
  • Compatibility: PASS — git diff origin/main -- action.yml is empty; @v1 callers are unaffected.

Upstream check: v0.6.4..v0.6.6 of arcade changes src/arcade/server.py and src/arcade/__main__.py in docstrings only. The rest is unit tests, the og.png share image and its og-card/ sources, and CHANGELOG/README text. The PUT /api/games/<slug>/versions/<version> contract is unchanged.

Not covered: CI only exercises http:// on play.localhost from ubuntu-latest, as before; this bump does not change that.

Merge gate: the change touches .github/workflows/*, which is on the do-not-auto-merge list, so the PR is left open for owner review.

This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).


drafted by Claude on behalf of Daniel Stephenson

@dmccoystephenson
dmccoystephenson merged commit 8d4a63d into main Oct 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant